Re: [RFT, PATCH v1 1/1] platform/x86: dell-smo8800: Convert to be a platform driver

From: Andy Shevchenko
Date: Fri Aug 06 2021 - 05:04:25 EST


On Thu, Aug 05, 2021 at 09:22:21PM +0200, Pali Rohár wrote:
> On Tuesday 03 August 2021 22:40:39 Andy Shevchenko wrote:
> > ACPI core in conjunction with platform driver core provides
> > an infrastructure to enumerate ACPI devices. Use it in order
> > to remove a lot of boilerplate code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Tested on Dell Latitude E6440. After applying this patch /dev/freefall
> device is created and can be opened (for waiting for disk fall). Also
> interrupt is registered in /proc/interrupts file:
>
> 23: 0 0 0 0 IR-IO-APIC 23-edge smo8800
>
> But I have not done real hard disk fall on this machine :-) so I guess
> it would work as before applying this patch.

At least the change doesn't touch any functional parts except device driver
enumeration.

> Reviewed-by: Pali Rohár <pali@xxxxxxxxxx>
> Tested-by: Pali Rohár <pali@xxxxxxxxxx>

Thank you!

--
With Best Regards,
Andy Shevchenko