Re: [PATCH] mailmap: update email address of Matthias Fuchs

[Marc Kleine-Budde]

On 09.08.2021 17:22:51, Stefan Mätje wrote:
> > Speaking of that patch. Can you please create an entry in the
> > MAINTAINERS file, too? I suggest to add yourself as M: and the
> > socketcan@e.u as R:. The change in the MAINTAINERS file will be a second
> > patch in that series. Just include it the next iteration of that series.
> 
> Do you think of something like the patch below?

ACK

> I'm curious. Shouldn't there be similar entries for the drivers from
> Vincent (drivers/net/can/usb/etas_es58x/) and the PEAK driver family
> (drivers/net/can/peak_canfd/)? Why are they not there?

They haven't included a MAINTAINERS entry in the patch series and I
forgot to enforce it :)

> Have I misunderstood something?
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 41fcfdb24a81..f25e3f79b392 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4111,6 +4111,14 @@ F:       include/uapi/linux/can/error.h
>  F:     include/uapi/linux/can/netlink.h
>  F:     include/uapi/linux/can/vxcan.h
>  
> +CAN NETWORK DRIVERS ESD HARDWARE

This usually starts with the company's name or the driver name, so
something like "ESD PCIe/402 CAN DRIVER" and a separate entry for the
USB driver or "ESD CAN NETWORK DRIVERS" if you want to have a single
entry.

> +M:     Stefan Mätje <stefan.maetje@xxxxxx>
> +R:     socketcan@xxxxxx
> +L:     linux-can@xxxxxxxxxxxxxxx
> +S:     Maintained
> +F:     drivers/net/can/esd/
> +F:     drivers/net/can/usb/esd_usb2.c
> +
>  CAN NETWORK LAYER
>  M:     Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
>  M:     Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> 
> 
> > > and his email address shows up in MODULE_AUTHOR() macro. He also left
> > > our company already.
> > 
> > In newly added changes, it makes sense that all email addresses are
> > working. :D
> 
> So I'll remove his stale email address together with the
> MODULE_AUTHOR() macro and file the authorship credits in a changed
> copyright history at the top of the source files.

Yes, his name but with the socketcan@e.u email in MODULE_AUTHOR().
Regarding the top of the file's copyright information, the last patch
only mentions 2 iterations of "esd" but no "real" people nor email
addresses. I don't know what's you company's policy for the copyright
line is, I don't mind adding Thomas, but use the socketcan@e.u email.
People tend to look at the source file in case of problems, so better
have working addresses there.

Regarding the Co-Developed and Signed-off-by: Thomas posted the patches
back in 2015 with his email address, so use it for the Co-Developed and
Signed-off-by in your patch, too. This seems (or is) a bit inconsistent,
but the S-o-b's should record the history of the patch.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature