Re: [PATCH] selftests/damon/debugfs_attrs: Add missing execute permission
From: SeongJae Park
Date: Tue Aug 10 2021 - 10:09:13 EST
From: SeongJae Park <sjpark@xxxxxxxxx>
On Tue, 10 Aug 2021 13:27:44 +0200 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Aug 10, 2021 at 11:20:50AM +0000, SeongJae Park wrote:
> > From: SeongJae Park <sjpark@xxxxxxxxx>
> > Commit 04edafbc0c07 ("mm/damon: add user space selftests") of
> > linux-mm gives no execute permission to 'debugfs_attrs.sh' file.
> > This results in a DAMON selftest failure as below:
> > $ make -C tools/testing/selftests/damon run_tests
> > make: Entering directory '/home/sjpark/linux/tools/testing/selftests/damon'
> > TAP version 13
> > 1..1
> > # selftests: damon: debugfs_attrs.sh
> > # Warning: file debugfs_attrs.sh is not executable, correct this.
> > not ok 1 selftests: damon: debugfs_attrs.sh
> > make: Leaving directory '/home/sjpark/linux/tools/testing/selftests/damon'
> > To solve the problem, this commit adds the execute permission for
> > 'debugfs_attrs.sh' file.
> >  https://github.com/hnaz/linux-mm/commit/04edafbc0c07
> > Signed-off-by: SeongJae Park <sjpark@xxxxxxxxx>
> > ---
> > tools/testing/selftests/damon/debugfs_attrs.sh | 0
> > 1 file changed, 0 insertions(+), 0 deletions(-)
> > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
> > diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> > old mode 100644
> > new mode 100755
> > --
> > 2.17.1
> Why not fix the tools to execute the file properly as changing the mode
> of a file does not work well with all tools that we use (i.e. patch
Ok, It sounds make some sense. Hence, I posted this patch: