Re: [PATCH v14 022/138] mm/filemap: Add __folio_lock_or_retry()

From: David Howells
Date: Tue Aug 10 2021 - 11:35:57 EST


Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> Convert __lock_page_or_retry() to __folio_lock_or_retry(). This actually
> saves 4 bytes in the only caller of lock_page_or_retry() (due to better
> register allocation) and saves the 14 byte cost of calling page_folio()
> in __folio_lock_or_retry() for a total saving of 18 bytes. Also use
> a bool for the return type.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>