[PATCH 5.4 75/85] spi: meson-spicc: fix memory leak in meson_spicc_remove

From: Greg Kroah-Hartman
Date: Tue Aug 10 2021 - 13:39:52 EST


From: Dongliang Mu <mudongliangabcd@xxxxxxxxx>

commit 8311ee2164c5cd1b63a601ea366f540eae89f10e upstream.

In meson_spicc_probe, the error handling code needs to clean up master
by calling spi_master_put, but the remove function does not have this
function call. This will lead to memory leak of spicc->master.

Reported-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
Fixes: 454fa271bc4e("spi: Add Meson SPICC driver")
Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
Link: https://lore.kernel.org/r/20210720100116.1438974-1-mudongliangabcd@xxxxxxxxx
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/spi/spi-meson-spicc.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/spi/spi-meson-spicc.c
+++ b/drivers/spi/spi-meson-spicc.c
@@ -597,6 +597,8 @@ static int meson_spicc_remove(struct pla

clk_disable_unprepare(spicc->core);

+ spi_master_put(spicc->master);
+
return 0;
}