Re: [RFC 09/11] tools: gpio: Add new hardware clock type
From: Linus Walleij
Date: Wed Aug 11 2021 - 05:11:38 EST
On Sat, Jul 31, 2021 at 8:16 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> On Thu, Jul 29, 2021 at 08:17:22PM -0700, Dipen Patel wrote:
> > On 6/27/21 4:36 AM, Linus Walleij wrote:
> > > On Sat, Jun 26, 2021 at 1:48 AM Dipen Patel <dipenp@xxxxxxxxxx> wrote:
> > >
> > >> gpiolib-cdev is extended to support hardware clock type, this
> > >> patch reflects that fact.
> > >>
> > >> Signed-off-by: Dipen Patel <dipenp@xxxxxxxxxx>
> > > (...)
> > >> case 'w':
> > >> config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME;
> > >> break;
> > >> + case 't':
> > >> + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE;
> > >> + break;
> > > After the checking of the command line options we need a small sanity
> > > check so we don't try to enable both realtime and hardware clock
> > > at the same time, we will only be able to request one of them.
> > This will any way fail at gpiolib-cdev layer. Do we want to add it here
> > as well?
> I can't speak for Linus, but I'm fine with it as is as it allows the tool
> to be used to exercise the sanity check in the kernel.
Fair enough, that sounds useful. Go ahead with this as-is.