Re: [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base property

From: Linus Walleij
Date: Wed Aug 11 2021 - 08:41:04 EST


On Wed, Aug 4, 2021 at 4:44 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Aug 04, 2021 at 03:44:33PM +0300, Serge Semin wrote:
> > Thus, yes, I think we need to make sure here that the property
> > is only used in framework of the kernel and isn't passed via
> > inappropriate paths like DT/ACPI fw so not to get into the
> > maintainability troubles in future.
>
> Got it. I'll add the additional check in next version.

This seems reasonable for me, if you can get this done with
some kind of elegance.

Maybe use the "linux,gpio-base" property as mentioned so it is
clear that this is a Linux-internal thing only.

Yours,
Linus Walleij