Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly
From: Christoph Hellwig
Date: Thu Aug 12 2021 - 05:22:23 EST
On Wed, Aug 11, 2021 at 12:05:42AM -0700, John Hubbard wrote:
> - if (unlikely(!try_get_page(page)))
> + if (unlikely(try_get_compound_head(page, 1) == NULL))
Why not a simple ! instead of the == NULL?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>