Re: [PATCH v4 11/15] pci: Add pci_iomap_shared{,_range}

From: Christoph Hellwig
Date: Fri Aug 13 2021 - 04:07:56 EST


On Wed, Aug 04, 2021 at 05:52:14PM -0700, Kuppuswamy Sathyanarayanan wrote:
> +extern void __iomem *pci_iomap_shared(struct pci_dev *dev, int bar,
> + unsigned long max);
> +extern void __iomem *pci_iomap_shared_range(struct pci_dev *dev, int bar,
> + unsigned long offset,
> + unsigned long maxlen);

No need for externs here.

> +/**
> + * pci_iomap_shared_range - create a virtual shared mapping cookie for a
> + * PCI BAR

This reads like completely garbage from a markow chain.