Re:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string

From: 李扬韬
Date: Fri Aug 13 2021 - 10:55:31 EST


发件人:Chao Yu <chao@xxxxxxxxxx>
发送日期:2021-08-13 22:41:02
收件人:"李扬韬" <frank.li@xxxxxxxx>
抄送人:jaegeuk@xxxxxxxxxx,linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx
主题:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:17, 李扬韬 wrote:
>> HI Chao,
>>
>> From: Chao Yu <chao@xxxxxxxxxx>
>> Date: 2021-08-13 22:09:53
>> To: Yangtao Li <frank.li@xxxxxxxx>,jaegeuk@xxxxxxxxxx
>> Cc: linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:01, Yangtao Li wrote:
>>>> Do not use numbers but strings to improve readability when flag is set.
>>>
>>> This breaks output rule of sysfs entry, see below link:
>>>
>> Which rule? one entry should show one value?
>
>Yes, one value per file please, which is suggested by Greg.
>
>https://lkml.org/lkml/2021/6/3/319
>
>>
>> But I see that:
>> # cat /sys/fs/f2fs/<disk>/features
>> encryption, quota_ino, verity, pin_file
>>
>> So the format of features also wrong?
>
> What: /sys/fs/f2fs/<disk>/features
> Date: July 2017
> Contact: "Jaegeuk Kim" <jaegeuk@xxxxxxxxxx>
> Description: <deprecated: should use /sys/fs/f2fs/<disk>/feature_list/

OK, So Maybe we can make something like following?

/sys/fs/f2fs/<disk>/sbi_status/fsck

Yangtao