Re: [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance

[John Garry]

On 13/08/2021 17:01, Robin Murphy wrote:
> > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c 
> > b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > index 235f9bdaeaf223b..c81cd929047f573 100644
> > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > @@ -1747,15 +1747,16 @@ static int arm_smmu_atc_inv_master(struct 
> > arm_smmu_master *master)
> >   {
> >       int i;
> >       struct arm_smmu_cmdq_ent cmd;
> > +    struct arm_smmu_cmdq_batch cmds = {};
>
> BTW, it looks like this has crossed over with John's patch removing these.

It is only called from arm_smmu_disable_ats(), so not hot-path by the 
look for it. Or who even has ats HW ...?

But it should be at least cleaned-up for consistency. Leizhen?

Thanks,
John