Re: [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag

[Hannes Reinecke]

On 8/14/21 9:39 AM, Christoph Hellwig wrote:
> On Fri, Aug 13, 2021 at 08:17:45PM -0700, Bart Van Assche wrote:
> > On 8/13/21 6:49 AM, John Garry wrote:
> > > It is never read. Setting it and the request tag seems dodgy
> > > anyway.
> >
> > This is done because there is code in the SCSI error handler that may
> > allocate a SCSI command without allocating a tag. See also
> > scsi_ioctl_reset().
>
> Yes.  Hannes had a great series to stop passing the pointless scsi_cmnd
> to the reset methods.  Hannes, any chance you coul look into
> resurrecting that?
Sure.

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer