Re: [PATCH] mm, slub: add cpus_read_lock/unlock() for slab_mem_going_offline_callback()

From: David Hildenbrand
Date: Mon Aug 16 2021 - 04:23:56 EST

On 16.08.21 10:17, Stephen Rothwell wrote:
Hi David,

On Mon, 16 Aug 2021 10:04:13 +0200 David Hildenbrand <david@xxxxxxxxxx> wrote:

On 16.08.21 09:46, qiang.zhang@xxxxxxxxxxxxx wrote:
From: "Qiang.Zhang" <qiang.zhang@xxxxxxxxxxxxx>

The flush_all_cpus_locked() should be called with cpus_read_lock/unlock(),
ensure flush_cpu_slab() can be executed on schedule_on CPU.

Fixes: 1c84f3c91640 ("mm, slub: fix memory and cpu hotplug related lock ordering issues")

Which branch contains this commit? At least not linux.git or linux-next

It is Andrew's mmotm which is included in linux-next but gets rebased

Maybe I am blind or need more coffee:

often, so, for example, that SHA1 is no longer valid in linux-next
today (is is now fd917c6407fb).

This (unfortunately) make Fixes tags less useful for mmotm :-(

Right, and it somewhat makes sense, because Andrew will actually squash patches before sending them further upstream.

Ideally, such fixes should be discussed in the respective patch series, because before they go upstream, they are still under development.


David / dhildenb