Re: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init

From: Selvin Xavier
Date: Mon Aug 16 2021 - 05:17:01 EST


On Mon, Aug 16, 2021 at 2:26 PM Dinghao Liu <dinghao.liu@xxxxxxxxxx> wrote:
>
> Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock()
> in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock()
> in the error handling path of bnxt_re_register_netdev(), which may
> cause a deadlock. This bug is suggested by a static analysis tool,
> please advise.
>
> Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities")
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>

Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature