Re: [PATCH v6 1/2] mm,hwpoison: fix race with hugetlb page allocation
From: HORIGUCHI NAOYA(堀口 直也)
Date: Tue Aug 17 2021 - 01:40:55 EST
On Mon, Aug 16, 2021 at 10:56:46AM -0700, Luck, Tony wrote:
> On Tue, Aug 17, 2021 at 02:12:07AM +0900, Naoya Horiguchi wrote:
> > This dump indicates that HWPoisonHandlable() returned false due to
> > the lack of PG_lru flag. In older code before 5.13, get_any_page() does
> > retry with shake_page(), but does not since 5.13, which seems to me
> > the root cause of the issue. So my suggestion is to call shake_page()
> > when HWPoisonHandlable() is false.
> > Could you try checking that the following diff fixes the issue?
> > I could still have better fix (like inserting shake_page() to other
> > retry paths in get_any_page()), but the below is the minimum one.
> Tried it ... and it works! Injected and recovered from a thousand
> errors without seeing any problems.
Thank you for testing, I've submitted a patch just now.