Re: [PATCH v3 5/6] interconnect: qcom: Add MSM8996 interconnect provider driver

From: Bjorn Andersson
Date: Tue Aug 17 2021 - 23:31:56 EST

On Tue 10 Aug 23:37 CDT 2021, Yassine Oudjana wrote:
> diff --git a/drivers/interconnect/qcom/msm8996.c b/drivers/interconnect/qcom/msm8996.c
> +DEFINE_QNODE(mas_cnoc_a1noc, MSM8996_MASTER_CNOC_A1NOC, 8, 116, -1, true, -1, 0, -1, MSM8996_SLAVE_A1NOC_SNOC);

Unless there's strong reasons against, I really would like for us to
follow sc7280 and avoid the DEFINE_QNODE() macro for defining the nodes.

That said, I really appreciate your work on bringing us an interconnect
provider for MSM8996!