Re: linux-next: build warning after merge of the i2c tree

From: Jie Deng
Date: Wed Aug 18 2021 - 03:15:26 EST

On 2021/8/18 15:04, Stephen Rothwell wrote:
Hi Jie,

On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <jie.deng@xxxxxxxxx> wrote:
On 2021/8/18 14:29, Stephen Rothwell wrote:
Hi all,

After merging the i2c tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
208 | struct device *pdev = vdev->dev.parent;
| ^~~~

Introduced by commit

8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")
Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.

When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.

Thanks Stephen. I will send an additional patch to fix it.