Re: [PATCH 1/2] net: mii: make mii_ethtool_gset() return void

From: Andy Shevchenko
Date: Wed Aug 18 2021 - 04:50:25 EST

On Tue, Aug 17, 2021 at 05:39:04PM -0700, Jakub Kicinski wrote:
> On Tue, 17 Aug 2021 21:34:42 +0300 Pavel Skripkin wrote:
> > mii_ethtool_gset() does not return any errors. We can make it return
> > void to simplify error checking in drivers, that rely on return value
> > of this function.
> >
> > Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
> This breaks the build and therefore would be a nuisance in bisection.
> Please squash the changes or invert the order.

Please invert the order. You will need slightly different justification for the
PCH GBE patch. Feel free to add my

Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

to the PCH GBE one.

With Best Regards,
Andy Shevchenko