Re: [PATCH] dt-bindings: memory: convert Samsung Exynos DMC to dtschema

From: Rob Herring
Date: Wed Aug 18 2021 - 10:31:38 EST


On Mon, Aug 16, 2021 at 3:32 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>
> On 16/08/2021 09:53, Lukasz Luba wrote:
> > Hi Krzysztof,
> >
> > On 8/13/21 1:54 PM, Krzysztof Kozlowski wrote:
> >> Convert Samsung Exynos5422 SoC frequency and voltage scaling for
> >> Dynamic Memory Controller to DT schema format using json-schema.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> >> ---
> >> .../memory-controllers/exynos5422-dmc.txt | 84 -----------
> >> .../samsung,exynos5422-dmc.yaml | 137 ++++++++++++++++++
> >> MAINTAINERS | 2 +-
> >
> > I'm not an expert in this DT scripts and why it complains. Maybe it
> > complains because the "samsung,exynos-ppmu" is defined in the .txt
> > file... (?)
> > Although, in general looks OK.
> >
> > Acked-by: Lukasz Luba <lukasz.luba@xxxxxxx>
>
> I think the warning (triggered by DT_CHECKER_FLAGS=-m) can be ignored
> because it complains about compatible in example which is not present in
> the bindings. Usually it means someone wrote example not matching the
> bindings (e.g. a typo in compatible) but here it is on purpose.

Ultimately, it will mean the binding is undocumented (or a typo). But
right now, it means the binding is undocumented with a schema. It's
off by default because there's still about 80 warnings. It's turned on
for the bot so we don't add more. So please don't ignore it.

Rob