Re: [PATCH v2] usb: gadget: mv_u3d: request_irq() after initializing UDC

From: Felipe Balbi
Date: Wed Aug 18 2021 - 10:33:48 EST



Nadezda Lutovinova <lutovinova@xxxxxxxxx> writes:

> If IRQ occurs between calling request_irq() and mv_u3d_eps_init(),
> then null pointer dereference occurs since u3d->eps[] wasn't
> initialized yet but used in mv_u3d_nuke().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Fixes: 90fccb529d24 ("usb: gadget: Gadget directory cleanup - group UDC drivers")
> Signed-off-by: Nadezda Lutovinova <lutovinova@xxxxxxxxx>

Thanks for updating so quickly:

Acked-by: Felipe Balbi <balbi@xxxxxxxxxx>

--
balbi