Re: [PATCH 02/30] v4l: vxd-dec: Create mmu programming helper library

From: Greg KH
Date: Wed Aug 18 2021 - 10:37:26 EST

On Wed, Aug 18, 2021 at 07:40:09PM +0530, wrote:
> From: Sidraya <>
> The IMG D5520 has an MMU which needs to be programmed with all
> memory which it needs access to. This includes input buffers,
> output buffers and parameter buffers for each decode instance,
> as well as common buffers for firmware, etc.
> Functions are provided for creating MMU directories (each stream
> will have it's own MMU context), retrieving the directory page,
> and mapping/unmapping a buffer into the MMU for a specific MMU context.
> Also helper(s) are provided for querying the capabilities of the MMU.
> Signed-off-by: Buddy Liong <buddy.liong@xxxxxx>
> Signed-off-by: Angela Stegmaier <angelabaker@xxxxxx>
> Signed-off-by: Sidraya <>
> ---
> drivers/staging/media/vxd/common/imgmmu.c | 782 ++++++++++++++++++++++
> drivers/staging/media/vxd/common/imgmmu.h | 180 +++++

Why are you adding new stuff to staging? Why can it not just go to the
"real" part of the kernel?

If it is to go into staging, we need a TODO file that lists what needs
to be done to get it out of staging.


greg k-h