Re: [PATCH v2 06/63] cxl/core: Replace unions with struct_group()

From: Dan Williams
Date: Wed Aug 18 2021 - 18:36:38 EST


On Tue, Aug 17, 2021 at 11:06 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> Use the newly introduced struct_group_typed() macro to clean up the
> declaration of struct cxl_regs.
>
> Cc: Alison Schofield <alison.schofield@xxxxxxxxx>
> Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> Cc: Ira Weiny <ira.weiny@xxxxxxxxx>
> Cc: Ben Widawsky <ben.widawsky@xxxxxxxxx>
> Cc: linux-cxl@xxxxxxxxxxxxxxx
> Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Looks good and tests ok here:

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>