RE: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

From: Sherry Sun
Date: Wed Aug 18 2021 - 21:27:58 EST


Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: 2021年8月18日 22:05
> To: Sherry Sun <sherry.sun@xxxxxxx>
> Cc: jirislaby@xxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value
>
> On Tue, Aug 17, 2021 at 02:30:58PM +0800, Sherry Sun wrote:
> > From: Andy Duan <fugang.duan@xxxxxxx>
> >
> > Register offset needs to be applied on mapbase also.
> > dma_tx/rx_request use the physical address of UARTDATA.
> > Register offset is currently only applied to membase (the
> > corresponding virtual addr) but not on mapbase.
> >
> > Reviewed-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> > Acked-by: Fugang Duan <fugang.duan@xxxxxxx>
> > Signed-off-by: Adriana Reus <adriana.reus@xxxxxxx>
> > Signed-off-by: Sherry Sun <sherry.sun@xxxxxxx>
> > ---
>
> Why is there no signed-off-by from the author?
>
> Please fix up.

Sure, will add it in V2, thanks!

>
> thanks,
>
> greg k-h