Re: [PATCH v3 06/20] platform/x86: intel_scu: Move to intel sub-directory

[Andy Shevchenko]

On Thu, Aug 19, 2021 at 6:33 AM Kate Hsuan <hpa@xxxxxxxxxx> wrote:
>
> Move intel_scu to intel sub-directory to improve readability.

Intel SCU

...

> -obj-$(CONFIG_INTEL_SCU_IPC)            += intel_scu_ipc.o
> -obj-$(CONFIG_INTEL_SCU_PCI)            += intel_scu_pcidrv.o
> -obj-$(CONFIG_INTEL_SCU_PLATFORM)       += intel_scu_pltdrv.o
> -obj-$(CONFIG_INTEL_SCU_WDT)            += intel_scu_wdt.o
> -obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += intel_scu_ipcutil.o

> +

Stray change?

...

> +obj-$(CONFIG_INTEL_SCU_IPC)            += scu/
> +obj-$(CONFIG_INTEL_SCU_PCI)            += scu/
> +obj-$(CONFIG_INTEL_SCU_PLATFORM)       += scu/
> +obj-$(CONFIG_INTEL_SCU_WDT)            += scu/
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += scu/

One entry is enough.

...

> +obj-$(CONFIG_INTEL_SCU_IPC)            += ipc.o
> +obj-$(CONFIG_INTEL_SCU_PCI)            += pcidrv.o
> +obj-$(CONFIG_INTEL_SCU_WDT)            += wdt.o

This is not an equivalent. Please, use the same approach as below.

> +intel_scu_pltdrv-y                     := pltdrv.o
> +obj-$(CONFIG_INTEL_SCU_PLATFORM)       += intel_scu_pltdrv.o
> +intel_scu_ipcutil-y                    := ipcutil.o
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += intel_scu_ipcutil.o

-- 
With Best Regards,
Andy Shevchenko