Re: [PATCH 0/5] PCI: endpoint: Add support for additional notifiers

From: Kishon Vijay Abraham I
Date: Thu Aug 19 2021 - 10:15:23 EST


Hi Manivannan,

On 16/06/21 5:29 pm, Manivannan Sadhasivam wrote:
> Hello,
>
> This series adds support for additional notifiers in the PCI endpoint
> framework. The notifiers LINK_DOWN, BME, PME, and D_STATE are generic
> for all PCI endpoints but there is also a custom notifier (CUSTOM) added
> to pass the device/vendor specific events to EPF from EPC.
>
> The example usage of all notifiers is provided in the commit description.

In my earlier comment I didn't mean you to provide example usage in
commit description. Rather to be used in a existing endpoint controller
driver and handled in endpoint function drivers. Otherwise no point in
adding them to the upstream kernel.

Thanks
Kishon

>
> Thanks,
> Mani
>
> Manivannan Sadhasivam (5):
> PCI: endpoint: Add linkdown notifier support
> PCI: endpoint: Add BME notifier support
> PCI: endpoint: Add PME notifier support
> PCI: endpoint: Add D_STATE notifier support
> PCI: endpoint: Add custom notifier support
>
> drivers/pci/endpoint/pci-epc-core.c | 89 +++++++++++++++++++++++++++++
> include/linux/pci-epc.h | 5 ++
> include/linux/pci-epf.h | 5 ++
> 3 files changed, 99 insertions(+)
>