Re: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init

From: Jason Gunthorpe
Date: Thu Aug 19 2021 - 14:02:27 EST


On Mon, Aug 16, 2021 at 04:55:31PM +0800, Dinghao Liu wrote:
> Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock()
> in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock()
> in the error handling path of bnxt_re_register_netdev(), which may
> cause a deadlock. This bug is suggested by a static analysis tool,
> please advise.
>
> Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities")
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/bnxt_re/main.c | 1 -
> 1 file changed, 1 deletion(-)

Applied to for-rc, thanks

Jason