Re: [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3

From: Fabio Estevam
Date: Thu Aug 19 2021 - 16:15:53 EST


Hi Nadezda,

On Thu, Aug 19, 2021 at 12:48 PM Nadezda Lutovinova
<lutovinova@xxxxxxxxx> wrote:
>
> If IRQ occurs between calling devm_request_threaded_irq() and
> initializing dwc3_imx->dwc3, then null pointer dereference occurs
> since dwc3_imx->dwc3 is used in dwc3_imx8mp_interrupt().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.

"necessary"

> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Nadezda Lutovinova <lutovinova@xxxxxxxxx>

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>