Re: [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX guest

From: Borislav Petkov
Date: Fri Aug 20 2021 - 12:58:44 EST


On Fri, Aug 20, 2021 at 09:42:55AM -0700, Kuppuswamy, Sathyanarayanan wrote:
> Reason for suggesting seperate function for tdx_* specific protected guest
> check is, we will be adding some exceptions for TDX features (like command
> line option used to override the default flags or when device filter
> support is disabled). Our current final version looks like below. Such
> customization are not good in generic intel_* function right?

Err, why?

TDX is Intel technology. That's like asking to have

sev_prot_guest_has() and amd_prot_guest_has() on AMD.

Maybe I still don't get what you're trying to achieve but from where I'm
standing that sounds wrong.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette