Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer

[Joe Perches]

On Sun, 2021-08-22 at 08:08 +0300, Kalle Valo wrote:
> Joe Perches <joe@xxxxxxxxxxx> writes:
> 
> > On Sat, 2021-08-21 at 17:14 +0000, Kalle Valo wrote:
> > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > 
> > > > Use %*ph format to print small buffer as hex string.
> > > > 
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > 
> > > Patch applied to wireless-drivers-next.git, thanks.
> > > 
> > > 502213fd8fca ray_cs: use %*ph to print small buffer
> > > 
> > 
> > There's one more of these in the same file but it's in an #ifdef 0 block...
> 
> I would rather remove the whole ifdef 0 block, patches welcome.
> 

It'd probably take you about 20 seconds if you do it yourself.

$ git grep -P -n '^\s*#\s*if\s+0\b' drivers/net/wireless/ray_cs.c
drivers/net/wireless/ray_cs.c:637:#if 0
drivers/net/wireless/ray_cs.c:2281:#if 0
drivers/net/wireless/ray_cs.c:2341:#if 0

Rather a bit more time if you want to do the whole kernel...

$ git grep -P -n '^\s*#\s*if\s+0\b' | wc -l
1558