Re: [PATCH] vsprintf and docs: Add X to %ph for upper case output

[Andy Shevchenko]

On Sun, Aug 22, 2021 at 11:57 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Sun, 2021-08-22 at 11:53 +0300, Andy Shevchenko wrote:
> > On Sun, Aug 22, 2021 at 11:45 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > On Sun, 2021-08-22 at 11:31 +0300, Andy Shevchenko wrote:

...

> > > +       return snprintf(buf, 16 * 2 + 2, "%16phNX\n", sn);
> >
> > > +       return scnprintf(buffer, PAGE_SIZE, "%16phNX\n", unique_id);
> >
> > I think you need to convert to sysfs_emit() in both cases.
>
> First things first...

Yep. and to avoid ping-pong style, first here is converting to
sysfs_emit*() since it's already in the kernel.

-- 
With Best Regards,
Andy Shevchenko