Re: [PATCH 3/3] checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit
From: Masahiro Yamada
Date: Tue Aug 24 2021 - 09:33:04 EST
On Mon, Aug 23, 2021 at 4:23 AM Ariel Marcovitch
> As opposed to the --diff option, --commit can get ref names instead of
> commit hashes.
> When using the --commit option, the script resets the working directory
> to the commit before the given ref, by adding '~' to the end of the ref.
> However, the 'HEAD' ref is relative, and so when the working directory
> is reset to 'HEAD~', 'HEAD' points to what was 'HEAD~'. Then when the
> script resets to 'HEAD' it actually stays in the same commit. In this
> case, the script won't report any cases because there is no diff between
> the cases of the two refs.
> Prevent the user from using HEAD refs.
> A better solution might be to resolve the refs before doing the
> reset, but for now just disallow such refs.
Better than doing nothing.
So, applied to linux-kbuild.
> Signed-off-by: Ariel Marcovitch <arielmarcovitch@xxxxxxxxx>
> scripts/checkkconfigsymbols.py | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
> index 875e9a2c14b2..6259698e662d 100755
> --- a/scripts/checkkconfigsymbols.py
> +++ b/scripts/checkkconfigsymbols.py
> @@ -103,6 +103,9 @@ def parse_options():
> if args.commit:
> + if args.commit.startswith('HEAD'):
> + sys.exit("The --commit option can't get use the HEAD ref")
> args.find = False
> if args.ignore: