Re: [PATCH 2/2] staging: r8188eu: Make some clean-ups in usbctrl_vendorreq()

From: Fabio M. De Francesco
Date: Tue Aug 24 2021 - 11:39:37 EST


On Tuesday, August 24, 2021 5:26:23 PM CEST Pavel Skripkin wrote:
> I found the problem:
>
> > mutex_lock(&dvobjpriv->usb_vendor_req_mutex);
> >
> > /* Acquire IO memory for vendorreq */
> > - pIo_buf = dvobjpriv->usb_vendor_req_buf;
> > + io_buf = dvobjpriv->usb_vendor_req_buf;
>
>
> I don't know from where mutex_lock() comes from. In staging-next I have
>
> _enter_critical_mutex(&dvobjpriv->usb_vendor_req_mutex, NULL);
>
> instead of
>
> mutex_lock(&dvobjpriv->usb_vendor_req_mutex);
>
Oh, I know where it comes from... :)

It's a patch of mine that is in the queue, waiting to be reviewed and applied.
Please see: https://lore.kernel.org/lkml/20210819221241.31987-1-fmdefrancesco@xxxxxxxxx/

Thanks,

Fabio
>
> With regards,
> Pavel Skripkin
>