Re: [PATCH 2/2] usb: dwc3: pci add property to allow user space role switch

From: Felipe Balbi
Date: Tue Aug 24 2021 - 12:55:12 EST



Hi,

"Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@xxxxxxx> writes:
> On 8/24/2021 9:47 PM, Felipe Balbi wrote:
>> "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@xxxxxxx> writes:
>>
>>> Hi
>>> On 8/24/2021 1:49 PM, Felipe Balbi wrote:
>>>> Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@xxxxxxx> writes:
>>>>
>>>>> For AMD platform there is a requirement to enable user space role
>>>>> switch from host to device and device to host by means of running
>>>>> following commands.
>>>>>
>>>>> HOST: echo host > /sys/class/usb_role/dwc3.0.auto-role-switch/role
>>>>> DEVICE: echo device > /sys/class/usb_role/dwc3.0.auto-role-switch/role
>>>> A more important question that needs to be answered: why?
>>>>
>>> Our customer platform is not completely capable of OTG i.e with type C
>>> controller it does not have PD to support role switching. Hence, they
>>> have script which triggers the role switch based on ACPI/EC interrupt.
>> sounds like some generalized version of this text should be added to
>> commit log.
>>
> Sure i will resubmit this patch with this description should be ok?

yup, sounds good. Thank you


--
balbi