Re: [PATCH v5 07/12] x86/traps: Add #VE support for TDX guest

From: Borislav Petkov
Date: Tue Aug 24 2021 - 13:46:43 EST


On Tue, Aug 24, 2021 at 10:32:13AM -0700, Kuppuswamy, Sathyanarayanan wrote:
> Mainly chose it avoid future name conflicts with KVM (tdx) calls. But

What name conflicts with KVM calls? Please explain.

> It is required to handle #VE exceptions raised by unhandled MSR
> read/writes.

Example? Please elaborate.

> Ok. I can check it. But there is only one statement after this call.
> So it may not be very helpful.

Looking at die_addr(), that calls the die notifier too. So do you
even *have* to call it here with VEFSTR? As yo say, there's only one
statement after that call and box is dead in the water after that so why
even bother...

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette