Re: [PATCH v5 09/12] x86/tdx: Wire up KVM hypercalls

From: Borislav Petkov
Date: Tue Aug 24 2021 - 14:28:41 EST


On Tue, Aug 24, 2021 at 11:11:43AM -0700, Kuppuswamy, Sathyanarayanan wrote:
> Since TDX code can be used by other hypervisor (non KVM case) we
> want to have a config to differentiate the KVM related calls.

You need to start explaining yourself better. WTH does "to differentiate
the KVM related calls" even mean? Differentiate for what?!

Our CONFIG space is a huuge mess. Adding another option better be
properly justified.

> Compiler raised version generation issue for __tdx_hypercall

-ENOTENOUGHINFO.

Try again.

> Yes. I will fix this in next version.

And here audit all your patchsets. All exports better be _GPL.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette