[PATCH 2/4] configfs: simplify the configfs_dirent_is_ready

From: Christoph Hellwig
Date: Wed Aug 25 2021 - 02:52:11 EST


Return the error directly instead of using a goto.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
fs/configfs/dir.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index cf08bbde55f3..5d58569f0eea 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -467,9 +467,8 @@ static struct dentry * configfs_lookup(struct inode *dir,
* not complete their initialization, since the dentries of the
* attributes won't be instantiated.
*/
- err = -ENOENT;
if (!configfs_dirent_is_ready(parent_sd))
- goto out;
+ return ERR_PTR(-ENOENT);

list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
if (sd->s_type & CONFIGFS_NOT_PINNED) {
@@ -493,7 +492,6 @@ static struct dentry * configfs_lookup(struct inode *dir,
return NULL;
}

-out:
return ERR_PTR(err);
}

--
2.30.2