Re: [PATCH] ANDROID: staging: add userpanic-dev driver

From: Greg Kroah-Hartman
Date: Thu Aug 26 2021 - 05:49:15 EST


On Thu, Aug 26, 2021 at 05:28:54PM +0800, Woody Lin wrote:
> Add char device driver 'userpanic-dev' that exposes an interface to
> userspace processes to request a system panic with customized panic
> message.
>
> Signed-off-by: Woody Lin <woodylin@xxxxxxxxxx>
> ---
> drivers/staging/android/Kconfig | 12 +++
> drivers/staging/android/Makefile | 1 +
> drivers/staging/android/userpanic-dev.c | 110 ++++++++++++++++++++++++

Why is this in staging? What is wrong with it that it can not just go
into the real part of the kernel? A TODO file is needed explaining what
needs to be done here in order for it to be accepted.

But why is this really needed at all? Why would userspace want to panic
the kernel in yet-another-way?

thanks,

greg k-h