Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

From: Denis Kirjanov
Date: Thu Aug 26 2021 - 11:19:31 EST


On 8/26/21, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> There are spelling mistakes in dev_err and dev_info messages. Fix them.
> []
>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
>> b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
> []
>> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> write_unlock_bh(&ctbl->lock);
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> dev_err(adap->pdev_dev,
>> "CLIP FW cmd failed with error %d, "
>> - "Connections using %pI6c wont be "
>> + "Connections using %pI6c won't be "
>> "offloaded",
>> ret, ce->addr6.sin6_addr.s6_addr);
>> return ret;
>> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> } else {
>> write_unlock_bh(&ctbl->lock);
>> dev_info(adap->pdev_dev, "CLIP table overflow, "
>> - "Connections using %pI6c wont be offloaded",
>> + "Connections using %pI6c won't be offloaded",
>> (void *)lip);
>
> This is an unnecessary cast.
> And these could coalesce the format fragments and add newlines too.

and fix the leftover in the comment:
./t4_hw.c:7185: * set wont be sent when we are flashing FW.


>
>
>