Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect

[Michael Straube]

On 8/28/21 11:31, Saurav Girepunje wrote:
> Remove the condition with no effect (if == else) in usb_intf.c
> file.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
> ---
>   drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index bb85ab77fd26..849563b54727 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
>   	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
>   	int ret = 0;
>
> -	if (pwrpriv->bInternalAutoSuspend)
> -		ret = 
> -	else
> -		ret = rtw_resume_process(padapter);
> +	ret = rtw_resume_process(padapter);
> +
>   	return ret;
>   }

Thanks for your patch. Perhaps this could be further simplified to:

int ret = rtw_resume_process(padapter);

return ret;

or even:

return rtw_resume_process(padapter);

Best regards,
Michael