Re: [PATCH v5 3/7] watchdog: f71808e_wdt: constify static array

From: Guenter Roeck
Date: Sat Aug 28 2021 - 12:07:51 EST


On Mon, Aug 09, 2021 at 06:20:33PM +0200, Ahmad Fatoum wrote:
> The fintek_wdt_names is meant for read-only use and is currently not
> modified. Mark it const to catch future writes.
>
> Suggested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> drivers/watchdog/f71808e_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
> index 3a0b29cb5854..8913747517fa 100644
> --- a/drivers/watchdog/f71808e_wdt.c
> +++ b/drivers/watchdog/f71808e_wdt.c
> @@ -112,7 +112,7 @@ MODULE_PARM_DESC(start_withtimeout, "Start watchdog timer on module load with"
> enum chips { f71808fg, f71858fg, f71862fg, f71868, f71869, f71882fg, f71889fg,
> f81803, f81865, f81866};
>
> -static const char *f71808e_names[] = {
> +static const char * const f71808e_names[] = {
> "f71808fg",
> "f71858fg",
> "f71862fg",