Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()

[Jonathan Cameron]

On Fri, 20 Aug 2021 12:17:46 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Fri, Aug 20, 2021 at 4:52 AM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
> > On 2021/8/20 1:20, Andy Shevchenko wrote:  
> > > On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:  
> > >> Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().  
> > > ...
> > >  
> > >>          ret = clk_prepare_enable(adc->adclk);
> > >> -       if (ret)
> > >> +       if (ret) {
> > >> +               clk_disable_unprepare(adc->pclk);
> > >>                  return ret;
> > >> +       }  
> > > Huh?!  
> > The pclk need be disabled, when enable adclk failed.
> >        ^                                                         ^^  
> 
> Indeed. I'm wondering if those clocks behave like a bulk or any
> combination is possible on a working case?

They are handled independently in other parts of the driver, so bulk
setting is going to be a mess.

>