Re: [PATCH Part1 v5 35/38] x86/sev: Register SNP guest request platform device

From: Brijesh Singh
Date: Tue Aug 31 2021 - 12:03:26 EST


Hi Dov,


On 8/31/21 6:37 AM, Dov Murik wrote:
+
+ if (!platform_device_register(&guest_req_device))
+ dev_info(&guest_req_device.dev, "secret phys 0x%llx\n", snp_secrets_phys);

Should you return the error code from platform_device_register() in case
it fails (returns something other than zero)?


Yes, I will fix it in next rev. Will return a non-zero on failure to register the device.

thanks