Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number
From: Leo Yan
Date: Thu Sep 02 2021 - 03:53:50 EST
On Wed, Sep 01, 2021 at 01:49:51PM -0300, Arnaldo Carvalho de Melo wrote:
> This doesn't explain that 'make -C tools/perf build-test' error, perhaps
> it is reusing the feature dump (feature detection), done without
> CORESIGHT=1, when building with CORESIGHT=1 :-\
> Anyway, please consider making the build fail when CORESIGHT=1 is passed
> explicitely and that tools/build/feature-libopencsd.c feature test fails
> instead of silently building the tool _without_ the explicitely asked
> for feature.
Sorry for inconvenience.
I have sent a patch to allow the build to report error when detect feature
failure for libopencsd .
It's obviously that there have another issue with 'make -C tools/perf
build-test' which should not build with option 'CORESIGHT=1' by
default. Please let me know if you want me to follow this issue or not.
p.s. I didn't use the patch linkage from lore.kernel.org, seems
the server is down when I try to fetch link from it.