Re: [PATCH] staging: r8188eu: os_dep: use kmemdup instead of kzalloc and memcpy

[Saurav Girepunje]

On 04/09/21 12:23 am, Phillip Potter wrote:
> On Fri, 3 Sept 2021 at 18:56, Saurav Girepunje
> <saurav.girepunje@xxxxxxxxx> wrote:
> > Fixes coccicheck warning:WARNING opportunity for kmemdup in ioctl_linux.c
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
> > ---
> >   drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> > index 81d4255d1785..495fadd2b8c8 100644
> > --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> > +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> > @@ -585,14 +585,12 @@ static int rtw_set_wpa_ie(struct adapter *padapter, char *pie, unsigned short ie
> >          }
> >
> >          if (ielen) {
> > -               buf = kzalloc(ielen, GFP_KERNEL);
> > +               buf = kmemdup(pie, ielen, GFP_KERNEL);
> >                  if (!buf) {
> >                          ret =  -ENOMEM;
> >                          goto exit;
> >                  }
> >
> > -               memcpy(buf, pie, ielen);
> > -
> >                  /* dump */
> >                  {
> >                          int i;
> > --
> > 2.32.0
>
> Dear Saurav,
>
> Looks good, thanks:
> Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
>
> Regards,
> Phil

Thanks for review Phil

Regards,
Saurav Girepunje