Re: [PATCH] iwlwifi: pnvm: Fix a memory leak in 'iwl_pnvm_get_from_fs()'

From: Kalle Valo
Date: Sun Sep 05 2021 - 02:13:48 EST

Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> A firmware is requested but never released in this function. This leads to
> a memory leak in the normal execution path.
> Add the missing 'release_firmware()' call.
> Also introduce a temp variable (new_len) in order to keep the value of
> 'pnvm->size' after the firmware has been released.
> Fixes: cdda18fbbefa ("iwlwifi: pnvm: move file loading code to a separate function")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Acked-by: Luca Coelho <luca@xxxxxxxxx>

Patch applied to wireless-drivers.git, thanks.

45010c080e6e iwlwifi: pnvm: Fix a memory leak in 'iwl_pnvm_get_from_fs()'