Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning

From: Jens Axboe
Date: Sun Sep 05 2021 - 23:04:21 EST


On 9/5/21 8:56 PM, Stephen Rothwell wrote:
> Hi Jens,
>
> On Thu, 2 Sep 2021 06:35:47 -0600 Jens Axboe <axboe@xxxxxxxxx> wrote:
>>
>> On 8/30/21 3:11 AM, Geert Uytterhoeven wrote:
>>> If CONFIG_BLK_DEBUG_FS=n:
>>>
>>> block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
>>> 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
>>> | ^~~~~~~~~
>>>
>>> Fix this by moving dd_queued() just before the sole function that calls
>>> it.
>>
>> Applied, thanks.
>
> Can we get this to Linus ASAP as he has now made warnings fatal, so
> this is causing lots of build failures.

Sure, it's actually the only branch I haven't sent off yet today. Will
do so now.

--
Jens Axboe