Re: [PATCH v2 1/2] selftests: KVM: align guest physical memory base address to 1GB

From: Mingwei Zhang
Date: Mon Sep 06 2021 - 15:57:02 EST


> 1gb may not be appropriate for all architectures and we don't want to _just_
> test 1gb aligned memslots. The alignment should be tied to the backing store,
> even if the test is hardcoded to use THP, that way the alignment logic works
> without modification if the backing store is changed.

Agree on that.
>
> I had a patch[1] that did this, let me go resurrect that series. My series got
> put on the backburner in favor of Yanan's series[2] which did a much better
> job of identifying/handling the host virtual address alignment, but IIRC my
> approach for handling GPA was correct.
>
> [1] https://lore.kernel.org/kvm/20210210230625.550939-6-seanjc@xxxxxxxxxx/
> [2] https://lkml.kernel.org/r/20210330080856.14940-1-wangyanan55@xxxxxxxxxx
>

Thanks for the info. I will use patch [1] instead of mine in the next version.

Regards.
-Mingwei