Re: [PATCH v4 0/9] fs/ntfs3: Use new mount api and change some opts

From: Konstantin Komarov
Date: Thu Sep 09 2021 - 12:39:11 EST




On 07.09.2021 18:35, Kari Argillander wrote:
> v3 link:
> lore.kernel.org/ntfs3/20210829095614.50021-1-kari.argillander@xxxxxxxxx
>
> This series will delete unnecessary mount options and rename some.
> Also this will convert ntfs3 to use new mount api. In my opinion we
> should get this in 5.15 because after that basically we have to have
> deprecated flag with new mount options. Let's try to avoid that if
> possible.
>
> v4:
> - Rebased top of the current ntfs3/master
> - Rename mount option (no)acs_rules -> (no)acsrules
> - Fix acs commit message acl -> acs (Thank Pali)
> v3:
> - Add patch "Convert mount options to pointer in sbi"
> - Add patch "Init spi more in init_fs_context than fill_super"
> - Add patch "Show uid/gid always in show_options"
> - Patch "Use new api for mounting" has make over
> - NLS loading is not anymore possible when remounting
> - show_options() iocharset printing is fixed
> - Delete comment that testing should be done with other
> mount options.
> - Add reviewed/acked-tags to 1,2,6,8
> - Rewrite this cover
> v2:
> - Rewrite this cover leter
> - Reorder noatime to first patch
> - NLS loading with string
> - Delete default_options function
> - Remove remount flags
> - Rename no_acl_rules mount option
> - Making code cleaner
> - Add comment that mount options should be tested
>
> Kari Argillander (9):
> fs/ntfs3: Remove unnecesarry mount option noatime
> fs/ntfs3: Remove unnecesarry remount flag handling
> fs/ntfs3: Convert mount options to pointer in sbi
> fs/ntfs3: Use new api for mounting
> fs/ntfs3: Init spi more in init_fs_context than fill_super
> fs/ntfs3: Make mount option nohidden more universal
> fs/ntfs3: Add iocharset= mount option as alias for nls=
> fs/ntfs3: Rename mount option no_acs_rules > (no)acsrules
> fs/ntfs3: Show uid/gid always in show_options()
>
> Documentation/filesystems/ntfs3.rst | 10 +-
> fs/ntfs3/attrib.c | 2 +-
> fs/ntfs3/dir.c | 8 +-
> fs/ntfs3/file.c | 4 +-
> fs/ntfs3/inode.c | 12 +-
> fs/ntfs3/ntfs_fs.h | 26 +-
> fs/ntfs3/super.c | 498 +++++++++++++++-------------
> fs/ntfs3/xattr.c | 2 +-
> 8 files changed, 290 insertions(+), 272 deletions(-)
>
>
> base-commit: 2e3a51b59ea26544303e168de8a0479915f09aa3
>

Applied, thanks for patches and review!

Best regards,
Konstantin