Re: [PATCH v2] drivers/cdrom: improved ioctl for media change detection
From: Phillip Potter
Date: Fri Sep 10 2021 - 04:00:03 EST
On Thu, Sep 09, 2021 at 06:25:35PM -0700, Randy Dunlap wrote:
> I have no problem with Jens's suggestion. It would look more like this:
> + __s64 last_media_change; /* Timestamp of the last detected media
> + * change in ms. May be set by caller, updated
> + * upon successful return of ioctl.
> + */
> + __u64 media_flags; /* various <struct> flags */
> #define MEDIA_CHANGED 0x1 /* Set to 1 by ioctl if last detected media */
> /* other bits of media_flags available for future use */
> and not having __u64 has_changed;
> which is overkill for a flag.
Yeah I like this, good idea. Thanks.