Re: [PATCH] iio: ep93xx: Make use of the helper function devm_platform_ioremap_resource()

From: Jonathan Cameron
Date: Sat Sep 11 2021 - 13:13:38 EST


On Wed, 8 Sep 2021 18:56:45 +0800
Cai Huoqing <caihuoqing@xxxxxxxxx> wrote:

> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>

+CC Alexander who wrote this driver.

Given this one is less active than the others you've sent I'll pick it up now.
(the others will wait a few days to see if we get reviews from anyone else).

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to see if it can find anything we missed.

Thanks,

Jonathan

> ---
> drivers/iio/adc/ep93xx_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ep93xx_adc.c b/drivers/iio/adc/ep93xx_adc.c
> index 8edd6407b7c3..fd5a9404c8dc 100644
> --- a/drivers/iio/adc/ep93xx_adc.c
> +++ b/drivers/iio/adc/ep93xx_adc.c
> @@ -156,15 +156,13 @@ static int ep93xx_adc_probe(struct platform_device *pdev)
> struct iio_dev *iiodev;
> struct ep93xx_adc_priv *priv;
> struct clk *pclk;
> - struct resource *res;
>
> iiodev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv));
> if (!iiodev)
> return -ENOMEM;
> priv = iio_priv(iiodev);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>